Skip to content

Retry pulling containers in Hive tests#14315

Merged
findepi merged 1 commit intotrinodb:masterfrom
ppalucha:pp/retry-hdp-containers-pull
Sep 28, 2022
Merged

Retry pulling containers in Hive tests#14315
findepi merged 1 commit intotrinodb:masterfrom
ppalucha:pp/retry-hdp-containers-pull

Conversation

@ppalucha
Copy link
Copy Markdown
Member

Description

Retry pulling hdp containers in tests. Should help in case of errors like:

+ docker-compose -f plugin/trino-hive-hadoop2/bin/../conf/docker-compose.yml pull --quiet

ERROR: for hadoop-master  b'Head "https://ghcr.io/v2/trinodb/testing/hdp3.1-hive/manifests/56": Get "https://ghcr.io/***?scope=repository%3Atrinodb%2Ftesting%2Fhdp3.1-hive%3Apull&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)'
Head "https://ghcr.io/v2/trinodb/testing/hdp3.1-hive/manifests/56": Get "https://ghcr.io/***?scope=repository%3Atrinodb%2Ftesting%2Fhdp3.1-hive%3Apull&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Error: Process completed with exit code 1.

Non-technical explanation

Make tests more resilient to temporary GitHub issues.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2022
@ppalucha ppalucha requested a review from jirassimok September 27, 2022 10:23
@findepi
Copy link
Copy Markdown
Member

findepi commented Sep 27, 2022

It's not only about HDP containers, right?

Let's rename this to "Retry pulling containers in Hive tests"

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Sep 27, 2022
@ppalucha ppalucha changed the title Retry pulling hdp containers in tests Retry pulling containers in Hive tests Sep 27, 2022
@findepi findepi merged commit dc03cff into trinodb:master Sep 28, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Sep 28, 2022

CI is red, but these are known failures occurring on master too, and being addressed in #14323

@github-actions github-actions bot added this to the 398 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry test

Development

Successfully merging this pull request may close these issues.

4 participants