Address leftover comments for pinot timestamp type tests from PR #14244#14311
Merged
hashhar merged 1 commit intotrinodb:masterfrom Oct 1, 2022
Merged
Address leftover comments for pinot timestamp type tests from PR #14244#14311hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
xiangfu0
changed the title
ebyhr
reviewed
Sep 27, 2022
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
ts-type-tests
branch
3 times, most recently
from
19feffc to
03d817b
Compare
hashhar
reviewed
Sep 28, 2022
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
ts-type-tests
branch
from
03d817b to
812c1da
Compare
ebyhr
approved these changes
Oct 1, 2022
Member
|
I have no remaining comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address leftover comments from PR #14244