Deprecate isXxxDecimal and minor code cleanup#14289
Merged
findepi merged 4 commits intotrinodb:masterfrom Sep 27, 2022
Merged
Conversation
The value provided is expected to be full micros, so it is just style update.
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/deprecate-isxxxdecimal-398cea
branch
2 times, most recently
from
127ba22 to
5b2af78
Compare
ebyhr
approved these changes
Sep 26, 2022
Comment on lines
130
to
133
Member
There was a problem hiding this comment.
How about using enhanced instanceof?
Deprecate isShortDecimal, isLongDecimal inspection methods. Idiomatic way of checking for long or short decimal is using `DecimalType.isShort`. This is in line with previous changes like 2fe7727.
findepi
force-pushed
the
findepi/deprecate-isxxxdecimal-398cea
branch
from
5b2af78 to
c653b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.