Use monotonic clock in Glue metrics#14258
Merged
findepi merged 2 commits intotrinodb:masterfrom Sep 26, 2022
Merged
Conversation
pettyjamesm
force-pushed
the
glue-metrics-nanotime
branch
from
c7bc808 to
0d03cb6
Compare
Member
This is probably not true
NTP should generally "smooth out" (stretch or condense seconds/ticks) |
findepi
approved these changes
Sep 23, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
glue-metrics-nanotime
branch
from
0d03cb6 to
acfb845
Compare
findepi
approved these changes
Sep 23, 2022
findepi
added
the
no-release-notes
Switches async glue API call timing to using Guava's Stopwatch instead of System.currentTimeMillis() to measure elapsed time, since the latter is not monotonic.
pettyjamesm
force-pushed
the
glue-metrics-nanotime
branch
from
acfb845 to
12aa495
Compare
findepi
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change usage of
System.currentTimeMillis()to Guava'sStopwatchin Glue API stats collection, sinceSystem.currentTimeMillis()is not guaranteed to be monotonic and therefore not ideal for measuring elapsed time. Metrics are still recorded in milliseconds.Non-technical explanation
No non-technical explanation is necessary.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: