Don't silently ignore failures in RPM test step in CI#14257
Merged
findepi merged 1 commit intotrinodb:masterfrom Sep 23, 2022
Merged
Don't silently ignore failures in RPM test step in CI#14257findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
Because the RPM test is a separate step, it requires other modules build in this job to be installed in the local repo, to avoid building most modules twice. This in turn requires to manually clean them later to avoid caching them in Github, because only dependencies should be cached.
nineinchnick
requested review from
ebyhr,
findepi and
hashhar
and removed request for
ebyhr
Member
Author
|
I forgot to mention in the commit message that I reverted b2888b4. Should I mention this? It did not revert cleanly anyway. |
findepi
approved these changes
Sep 23, 2022
| - name: Test Server RPM | ||
| run: | | ||
| export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}" | ||
| $RETRY bash -c "$MAVEN verify -B --strict-checksums -P ci -pl :trino-server-rpm || find core/trino-server-rpm/ -exec ls -ald {} +" |
Member
Author
There was a problem hiding this comment.
It's me who should be sorry, I broke this in #13367. I should have come up with a better PR title here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I just noticed the RPM test step is failing silently in the CI. I removed the code that ignores errors and also fixed the cause of failure (missing dependencies).
Because the RPM test is a separate step, it requires other modules build in this job to be installed in the local repo, to avoid building most modules twice. This, in turn, requires manually cleaning them later to avoid caching them in Github, because only dependencies should be cached.
Non-technical explanation
n/a
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: