Reset allowed-no-matching-node-period timeout on new nodes in cluster#14256
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Sep 24, 2022
Merged
Reset allowed-no-matching-node-period timeout on new nodes in cluster#14256losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
We allow for situation when there are no nodes in the cluster which match task requirement for timeout governed by node-scheduler.allowed-no-matching-node-period config variable. Previously if new node appeared in the cluster, but could not be used because it did not have enough free resources at given moment timeout counter was not reset. This commit changes the behaviour. If new node appears and then disappears again, the no-nodes timeout will be recounted again from zero.
losipiuk
force-pushed
the
lo/wait-on-no-nodes
branch
from
bdb9319 to
1e51671
Compare
arhimondr
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow for situation when there are no nodes in the cluster which match task requirement for timeout governed by
node-scheduler.allowed-no-matching-node-period config variable. Previously if new node appeared in the cluster, but could not be used because it did not have enough free resources at given moment timeout counter was not reset.
This commit changes the behaviour. If new node appears and then disappears again, the no-nodes timeout will be recounted again from zero.
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: