Skip to content

Link TODO to issue #14231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 1 commit into from
Sep 22, 2022
Merged

Link TODO to issue #14231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,8 @@ public void testShowCreateTable()
@Override
public void testReadMetadataWithRelationsConcurrentModifications()
{
// TODO: Enable this test after fixing "Task did not completed before timeout"
throw new SkipException("TODO");
// TODO: Enable this test after fixing "Task did not completed before timeout" (https://github.com/trinodb/trino/issues/14230)
Copy link
Copy Markdown
Member

@findepi findepi Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14230

Copy link
Copy Markdown
Member Author

@hashhar hashhar Sep 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment just to create link between this PR and the issue? Or do I need to do something?

EDIT: Nevermind, I see why it's useful. Otherwise hard to find what code the issue is talking about.

Copy link
Copy Markdown
Member

@findepi findepi Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment just to create link between this PR and the issue?

this

throw new SkipException("Test fails with a timeout sometimes and is flaky");
}

@Test
Expand Down