Support arbitrary aggregation functions during ANALYZE (v1)#14220
Closed
findepi wants to merge 4 commits intotrinodb:masterfrom
Closed
Support arbitrary aggregation functions during ANALYZE (v1)#14220findepi wants to merge 4 commits intotrinodb:masterfrom
findepi wants to merge 4 commits intotrinodb:masterfrom
Conversation
findepi
force-pushed
the
findepi/arbitrary-stats
branch
from
a5068df to
ccf6c0b
Compare
findepi
force-pushed
the
findepi/arbitrary-stats
branch
2 times, most recently
from
4224b00 to
0649485
Compare
findepi
changed the title
Member
Author
|
Here is an alternative version of this PR, which maintains backward compatibility: #14233 |
findepi
changed the title
findepi
changed the title
No need to record that, since it's a pure local operation.
`ColumnStatisticMetadata` is used in `StatisticAggregationsDescriptor` as a map key. Before the change, a hand-written serialization was used for that. After the change, the map is replaced with a list of key/value pairs for the purpose of the serialization.
The `ColumnStatisticType` enum was defining what is possible to collect during statistics collection. While looking generic, the chosen options matched exactly what stats Hive metastore collects. Different metadata storages may require different statistics to be collected, for example data sketches with some specific configuration.
findepi
force-pushed
the
findepi/arbitrary-stats
branch
from
0649485 to
4973016
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connector may ask engine to collect anything defined by
ColumnStatisticTypeSPI enum. This is convenient, but sometimes a connector needs to provide its own way of calculating statistics.For example, Iceberg statistics include
This has two components which are not supported today
This PR addresses the first limitation. It allows the connector to pick an aggregation function of its choice for statistics collection.