Fix javadoc in OptimizeMixedDistinctAggregations#14213
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Sep 23, 2022
Merged
Fix javadoc in OptimizeMixedDistinctAggregations#14213sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
force-pushed
the
ks/fix_comment
branch
2 times, most recently
from
6077922 to
d8f1635
Compare
martint
approved these changes
Sep 20, 2022
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Update the commit message to say "seems to indicate there are three GROUP BY ..." instead of "aggregations". That confused me for a while as I misinterpreted as "aggregation functions".
Javadoc seems to indicate there are three GROUP BY involved. However, there are only two GROUP BYs and GroupId operator.
sopel39
force-pushed
the
ks/fix_comment
branch
from
d8f1635 to
1506f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javadoc suggests that there are 3 aggregations involved. However, there are only 2 aggregations and GroupId operator.
Description
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: