Extract guice bindings for custom Iceberg catalog#14192
Merged
findepi merged 3 commits intotrinodb:masterfrom Sep 20, 2022
Merged
Extract guice bindings for custom Iceberg catalog#14192findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
findinpath
added
the
no-release-notes
alexjo2144
approved these changes
Sep 19, 2022
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
Looks good to me. It's nice to be able to move some of that test only code out of IcebergCatalogModule.
findepi
reviewed
Sep 19, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/MetastoreValidator.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Sep 19, 2022
Contributor
Author
There was a problem hiding this comment.
DecoratedHiveMetastoreModule creates a SharedHiveMetastoreCache which, depending on the CachingHiveMetastoreConfig configuration values may be enabled.
MetastoreValidator is there to specifically invalidate such a behaviour.
I think it makes sense to keep it.
Member
There was a problem hiding this comment.
In tests we don't need to validate that.
...test/java/io/trino/plugin/iceberg/catalog/file/TestingIcebergFileMetastoreCatalogModule.java
Outdated
Show resolved
Hide resolved
Allow tests to use a fully customized Iceberg catalog that is not necessarily backed by a `FileHiveMetastore` instance.
findinpath
force-pushed
the
iceberg-catalog-module-refactoring
branch
from
1e8b5a3 to
8ecbd5a
Compare
findepi
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow tests to use a fully customized Iceberg catalog
that is not necessarily backed by a
FileHiveMetastoreinstance.Non-technical explanation
Test infrastructure change
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: