Improve handling of interrupts in TrinoResultSet#14187
Merged
findepi merged 2 commits intotrinodb:masterfrom Sep 20, 2022
Merged
Improve handling of interrupts in TrinoResultSet#14187findepi merged 2 commits intotrinodb:masterfrom
findepi merged 2 commits intotrinodb:masterfrom
Conversation
Member
Author
|
|
Differentiate between interrupts happening in the calling thread and interrupts of the background thread. - use different message - the interrupts happening in the calling thread should result in full cancellation of the background thread. Previously they would close client, but wouldn't set `cancelled` flag.
findepi
force-pushed
the
findepi/jdbc-interclean
branch
from
19ba980 to
3e01a3e
Compare
Member
Author
|
@xiacongling please take a look |
losipiuk
reviewed
Sep 20, 2022
| catch (InterruptedException e) { | ||
| handleInterrupt(e); | ||
| client.close(); | ||
| rowQueue.clear(); |
Member
There was a problem hiding this comment.
why does cleaning rowQueue here matter?
Member
Author
There was a problem hiding this comment.
here it is probably not important. it's more like "why not?"
Member
Author
There was a problem hiding this comment.
discussed offline and agreed to keep
Contributor
|
LGTM. It is much clearer than before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differentiate between interrupts happening in the calling thread and
interrupts of the background thread.
cancellation of the background thread. Previously they would close
client, but wouldn't set
cancelledflag.