Extract TestJdbcStatement from TestJdbcConnection#14186
Merged
findepi merged 1 commit intotrinodb:masterfrom Sep 19, 2022
Merged
Conversation
Extract statement tests into new class. This makes them easier to find, especially that we already have `TestJdbcPreparedStatement` for testing aspects of _prepared_ statements.
findepi
added
test
no-release-notes
kokosing
approved these changes
Sep 19, 2022
findepi
deleted the
findepi/extract-testjdbcstatement-from-testjdbcconnection-560945
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract statement tests into new class. This makes them easier to find, especially that we already have
TestJdbcPreparedStatementfor testing aspects of prepared statements.