Generate specialized loops for aggregations#14178
Closed
dain wants to merge 7 commits intotrinodb:masterfrom
Closed
Generate specialized loops for aggregations#14178dain wants to merge 7 commits intotrinodb:masterfrom
dain wants to merge 7 commits intotrinodb:masterfrom
Conversation
dain
force-pushed
the
unwrap-aggergation
branch
2 times, most recently
from
29b1c37 to
618e98f
Compare
dain
commented
Sep 20, 2022
Member
Author
There was a problem hiding this comment.
mark these as @Experimental
dain
force-pushed
the
unwrap-aggergation
branch
3 times, most recently
from
d9c7480 to
3d7f2b5
Compare
This removes the requirement to track group count in addInput
The generated full loops have specialized paths for dictionary or run length encoded data, and for masked or unmasked data.
This can be disabled with compiler.specialized-aggregation-loops=false
dain
force-pushed
the
unwrap-aggergation
branch
from
3d7f2b5 to
a7a9ca7
Compare
Member
Author
|
This was rewritten in #19385 |
voonhous
added a commit
to voonhous/trino
that referenced
this pull request
Nov 30, 2025
voonhous
added a commit
to voonhous/trino
that referenced
this pull request
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The generate aggregations loops have specialized paths for dictionary or run length encoded data, and for masked or unmasked data. This change requires that aggregation function using the block and position calling convention have a separate
@BlockIndexfor each argument so dictionary and rle blocks can have a independent index.This change can be disabled with
compiler.specialized-aggregation-loops=falseincase we find problems.Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: