Fix incorrect parsing of timestamps in cast from varchar#14166
Merged
martint merged 1 commit intotrinodb:masterfrom Sep 17, 2022
Merged
Fix incorrect parsing of timestamps in cast from varchar#14166martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
There's some additional work needed. Per the SQL spec:
Therefore, if the string is a valid timestamp with time zone value, it needs to be parsed as such first and then converted to timestamp without time zone according to the rules of the cast operation between those types. |
0d751f4 to
26b6a95
Compare
findepi
reviewed
Sep 16, 2022
core/trino-main/src/test/java/io/trino/operator/scalar/timestamp/TestTimestamp.java
Outdated
Show resolved
Hide resolved
Trailing characters were incorrectly being treated as a timezone and ignored.
26b6a95 to
d5d1e7a
Compare
dain
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing characters were incorrectly being treated as a timezone and ignored.
Fixes #14164
Release notes
(x) Release notes are required, with the following suggested text: