In CI use runner's JDK17 by default#14142
In CI use runner's JDK17 by default#14142nineinchnick wants to merge 1 commit intotrinodb:masterfrom
Conversation
nineinchnick
force-pushed
the
default-ci-runner-java
branch
from
0fff4e5 to
d0a1f3a
Compare
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
This removes whatever little reproducibility we had. I'd argue to do opposite - explicitly unset JVM_HOME before running setup-java to make sure setup-java failures (even if silent) actually lead to failure.
nineinchnick
force-pushed
the
default-ci-runner-java
branch
from
d0a1f3a to
9ee291a
Compare
|
I agree that turning silent failures into visible ones is much better. I updated this PR. |
i am not sure this is sufficient do you know why setup-java failures can be silent? |
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
Yes, we should open an issue in https://github.com/actions/setup-java but I'm not sure how to describe it.
No, I have no idea. If there would be some network issue I'd expect more errors to get logged, instead of the action just terminating. |
nineinchnick
force-pushed
the
default-ci-runner-java
branch
from
9ee291a to
fd9671f
Compare
3 participants
Description
Fixes #14141. This makes me wonder if we should be downloading the JDK at all. We could replace
actions/setup-javawithactions/cache(since we do use it implicitly for the local Maven repository).Non-technical explanation
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: