Drop experimental qualifier for optimized parquet writer#14137
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Sep 17, 2022
Merged
Drop experimental qualifier for optimized parquet writer#14137raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
raunaqmorarka
requested review from
ebyhr,
findepi,
findinpath,
mosabua and
sopel39
findepi
approved these changes
Sep 15, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetWriterConfig.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
pqw-exp
branch
from
92ddd83 to
008ede9
Compare
Optimized parquet writer is already the default in delta lake. All the known incompatibilities with Hive and Spark were fixed in the hive connector by using legacy encodings where needed. Therefore, the experimental tag is no longer needed.
findepi
approved these changes
Sep 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimized parquet writer is already the default in delta lake.
All the known incompatibilities with Hive and Spark were fixed
in the hive connector by using legacy encodings where needed.
Therefore, the experimental tag is no longer needed.
Non-technical explanation
The
parquet.experimental-optimized-writer.enabledproperty is now deprecated.parquet.optimized-writer.enabledis the new property for enabling the optimized parquet writer.Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: