Skip to content

Support partitioned view in legacy Hive view reader#14073

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
yingxuanwangxuan:master
Sep 26, 2022
Merged

Support partitioned view in legacy Hive view reader#14073
ebyhr merged 1 commit intotrinodb:masterfrom
yingxuanwangxuan:master

Conversation

@yingxuanwangxuan
Copy link
Copy Markdown
Contributor

@yingxuanwangxuan yingxuanwangxuan commented Sep 9, 2022

Description

Fixes #14028

Non-technical explanation

Release notes

( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Hive
* Add support for partitioned view in legacy Hive view reader. ({issue}`14028`)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 9, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 9, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you submit CLA if you have not yet sent it?
https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 13, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

4 similar comments
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 王英旋.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

2 similar comments
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 17, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot cla-bot bot added the cla-signed label Sep 20, 2022
@yingxuanwangxuan yingxuanwangxuan force-pushed the master branch 3 times, most recently from 806a206 to 4d7c588 Compare September 21, 2022 01:58
@yingxuanwangxuan
Copy link
Copy Markdown
Contributor Author

Could you submit CLA if you have not yet sent it? https://github.com/trinodb/cla

@ebyhr Can you review this PR?

Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the commit title (≠PR title) as below?

Support partitioned view in legacy Hive view reader

@ebyhr ebyhr changed the title Support partitioned Hive views in Hive connector Support partitioned view in legacy Hive view reader Sep 26, 2022
@ebyhr ebyhr merged commit b7d55eb into trinodb:master Sep 26, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Sep 26, 2022

Merged, thanks!

@ebyhr ebyhr mentioned this pull request Sep 26, 2022
@yingxuanwangxuan
Copy link
Copy Markdown
Contributor Author

yingxuanwangxuan commented Sep 26, 2022

Merged, thanks!
@ebyhr Thank you for your review, I will continue to follow the latest development of the Trino community.

@github-actions github-actions bot added this to the 398 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Support partitioned Hive views in Hive connector

2 participants