Skip to content

Verify table just after adding column in BaseConnectorTest.testAddColumn #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Sep 10, 2022
Merged

Verify table just after adding column in BaseConnectorTest.testAddColumn #14057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,6 +1890,10 @@ public void testAddColumn()
assertQueryFails("ALTER TABLE " + table.getName() + " ADD COLUMN q bad_type", ".* Unknown type 'bad_type' for column 'q'");

assertUpdate("ALTER TABLE " + table.getName() + " ADD COLUMN a varchar(50)");
// Verify table state after adding a column, but before inserting anything to it
assertQuery(
"SELECT * FROM " + table.getName(),
"VALUES ('first', NULL)");
assertUpdate("INSERT INTO " + table.getName() + " SELECT 'second', 'xxx'", 1);
assertQuery(
"SELECT x, a FROM " + table.getName(),
Expand Down