Skip to content

Conversation

@colebow
Copy link
Member

@colebow colebow commented Sep 6, 2022

Description

This PR formalizes the release process into the Trino DEVELOPMENT.md file.

Non-technical explanation

Updating DEVELOPMENT.md.

Release notes

(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Sep 6, 2022
@colebow colebow requested a review from mosabua September 6, 2022 19:03
@github-actions github-actions bot added the docs label Sep 6, 2022
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum we should add links to example issue and PR for a release notes and do some more handwaving around the details of the rest of release build.

And link to https://github.com/trinodb/release-scripts

@colebow colebow force-pushed the colebow/readme-rn-update branch from 0219f46 to fd7dbe4 Compare September 12, 2022 17:19
@colebow colebow force-pushed the colebow/readme-rn-update branch 2 times, most recently from ce92c22 to caa4723 Compare September 12, 2022 17:23
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add that changes that affect multiple connectors or whatever .. are repeated so they are visible in all relevant sections directly.

Also if a PR fixes multiple things.. there can be multiple release note entries..

@colebow colebow force-pushed the colebow/readme-rn-update branch 2 times, most recently from 18a531f to 39cd54d Compare October 11, 2022 00:18
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good small and high level addition.

@colebow colebow requested a review from findepi October 14, 2022 16:37
@findepi
Copy link
Member

findepi commented Oct 15, 2022

Add release process section to README

Worth changing the PR title?

@colebow colebow changed the title Add release process section to README Add release process section to DEVELOPMENT.md Oct 17, 2022
@colebow
Copy link
Member Author

colebow commented Oct 31, 2022

@findepi is this good to go? PR title has been updated.

@findepi findepi requested review from martint and removed request for findepi November 4, 2022 09:45
@colebow colebow force-pushed the colebow/readme-rn-update branch from 39cd54d to a77493a Compare December 21, 2022 18:59
@colebow colebow force-pushed the colebow/readme-rn-update branch from a77493a to a1dae55 Compare January 30, 2023 17:51
@electrum electrum merged commit a57669e into trinodb:master Feb 6, 2023
@github-actions github-actions bot added this to the 407 milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants