-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add release process section to DEVELOPMENT.md #14020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a minimum we should add links to example issue and PR for a release notes and do some more handwaving around the details of the rest of release build.
And link to https://github.com/trinodb/release-scripts
0219f46 to
fd7dbe4
Compare
ce92c22 to
caa4723
Compare
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add that changes that affect multiple connectors or whatever .. are repeated so they are visible in all relevant sections directly.
Also if a PR fixes multiple things.. there can be multiple release note entries..
18a531f to
39cd54d
Compare
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good small and high level addition.
Worth changing the PR title? |
|
@findepi is this good to go? PR title has been updated. |
39cd54d to
a77493a
Compare
a77493a to
a1dae55
Compare
Description
This PR formalizes the release process into the Trino DEVELOPMENT.md file.
Non-technical explanation
Updating DEVELOPMENT.md.
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: