Hide Elasticsearch prefix-based pass-through query behind feature toggle

[kamil-rafalko]

Description

Hides Elasticsearch prefix-based pass-through query behind a feature toggle as discussed here #13390

The prefix-based pass-through query is deprecated. the raw_query table function should be used instead. To emphasize the fact that prefix-based pass-through query is deprecated before removing it at all, we decided to hide it behind the feature toggle.

Release notes

( ) This is not user-visible and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

[findepi]

Use PLANNER_CONTEXT.getTypeManager()

then you can revert TestingTypeManager changes

[kokosing]

I am not sure if it comes from you or is it is a bad rebase.

[kokosing]

please invert the condition then you can return fast and avoid indentation. You will avoid changing lines. Easier to review ;)

if (!constraint) {
  throw exception
}
the old code

[kokosing]

We don't do such testing ;) We try to avoid plumbing. Instead please create a new test class that extends abstract test query framewok and create new query runner that query pass through disabled. Then you can simply do assertQueryFail

[kokosing]

it is default value for boolean field

[findepi]

Hide Elasticsearch pass-through query behind feature toggle

We have two "pass-through queries"

• io.trino.plugin.elasticsearch.ElasticsearchMetadata#PASSTHROUGH_QUERY_SUFFIX
• io.trino.plugin.elasticsearch.ptf.RawQuery

please make sure the commit title indicates which one is getting behind a toggle and also add rationale to the commit message

[kokosing]

looks good to me % comments and CI

Thanks! It looks much simpler now!

[kokosing]

TestDisabledLegacyPassThroughQuery

[kokosing]

Please recommend that PTF (table function based) query pass through should be used instead.

[kokosing]

@findepi I would use elasticsearch.legacy-pass-through-query.enabled. WDYT?

[findepi]

i am ok either way

[findepi]

ES build is failing

[kokosing]

% comment. Please rebase and squash commits.

[kokosing]

You are using elasticsearch.legacy-pass-through-query.enabled in code. Please update.

[kamil-rafalko]

@kokosing @findepi @wendigo it's ready for review again. Can you take a look?

[kokosing]

Thank you!

[colebow]

Thank you for including the docs for this change as well!