Leverage Optional.orElseThrow to increase code readability#13941
Merged
findepi merged 2 commits intotrinodb:masterfrom Sep 5, 2022
Conversation
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/leverage-optional-orelsethrow-to-increase-code-readability-37e6d9
branch
from
23f9b77 to
e181918
Compare
ebyhr
approved these changes
Aug 31, 2022
Member
There was a problem hiding this comment.
I feel this change unrelates to Optional.orElseThrow leverage. Is separated a commit overkill?
Member
Author
There was a problem hiding this comment.
it's related.
The pattern
Optional<...> x = expr;
if (x.isEmpty()) {
throw;
}
should generally be avoided and you should use orElseThrow.
You should not, however, use orElseThrow where the variable would become unused. I.e. you shouldn't use it, if your goal is to check existence of some optional value. In such cases, i inlined the expression
Member
|
How much of this is manual changes vs how much is refactorings? Separate commits would be easier to review. |
Member
Author
Manual refactorings. |
findepi
force-pushed
the
findepi/leverage-optional-orelsethrow-to-increase-code-readability-37e6d9
branch
from
42258bd to
5da2233
Compare
Member
Author
|
(just rebased) |
Use of `Optional.orElseThrow` allows to verify the optional is not empty before assigning to a variable. This subsequently removes need for `Optional.get()` calls.
findepi
force-pushed
the
findepi/leverage-optional-orelsethrow-to-increase-code-readability-37e6d9
branch
from
5da2233 to
3e54f59
Compare
findepi
force-pushed
the
findepi/leverage-optional-orelsethrow-to-increase-code-readability-37e6d9
branch
from
3e54f59 to
604c4e3
Compare
findepi
deleted the
findepi/leverage-optional-orelsethrow-to-increase-code-readability-37e6d9
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
Optional.orElseThrowallows to verify the optional is not emptybefore assigning to a variable. This subsequently removes need for
Optional.get()calls.please ignore this section