Document named zone support for timestamp with time zone#13927
Merged
hashhar merged 1 commit intotrinodb:masterfrom Sep 26, 2022
Merged
Document named zone support for timestamp with time zone#13927hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
mosabua
requested changes
Aug 30, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
I think we should also add to TIME WITH TIME ZONE .. and explicitly mention that names are not supported (and why...)
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
from
0a367c0 to
8a61f5e
Compare
Member
|
Note that sphinx is complaining about the link - |
hashhar
reviewed
Sep 4, 2022
findepi
reviewed
Sep 5, 2022
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
3 times, most recently
from
5df3c9f to
cf6c0ac
Compare
Member
|
The CI is red. |
Member
|
@findepi I just checked out the branch locally and verified that the docs build works. The CI failure is misleading and caused by a flaky test from what I can tell. |
Member
|
CI hit #13288 |
findepi
reviewed
Sep 8, 2022
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
from
cf6c0ac to
7cd86fa
Compare
Member
|
thanks for updating #13927 (comment) but it seems you dropped |
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
3 times, most recently
from
3de399d to
f07e9c3
Compare
findepi
requested changes
Sep 17, 2022
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
from
f07e9c3 to
2335399
Compare
findepi
approved these changes
Sep 26, 2022
hashhar
approved these changes
Sep 26, 2022
jhlodin
force-pushed
the
jl/timestamp-poli-timezone
branch
from
2335399 to
e9a5d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe how a named time zone is supported by the
timestamp(p) with time zonetype with an exampleImprovement
Type documentation
Describe an additional supported use of Trino types
Related issues, pull requests, and links
Follow up on discussion in #7912 (comment)
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: