Push varchar non-equality comparisons into PostgreSQL#13894
Push varchar non-equality comparisons into PostgreSQL#13894findepi wants to merge 1 commit intotrinodb:masterfrom
Conversation
This enables by default an existing feature.
| } | ||
|
|
||
| @Config("postgresql.experimental.enable-string-pushdown-with-collate") | ||
| @Config("postgresql.enable-string-pushdown-with-collate") |
There was a problem hiding this comment.
Does it require docs update in this PR or in a follow-up?
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
It'll currently degrade performance for equality as well.
See CollationAwareQueryBuilder. We should probably make CollationAwareQueryBuilder use collations only for inequalities to improve it.
Good point. Do we want this to be documented?
Good idea. Also, some values should be easy to compare regardless of case-sensitivity (I'm consciously not considering "arbitrary collections"). See #13896. |
Let's document this. |
findepi
deleted the
findepi/push-varchar-non-equality-comparisons-into-postgresql-675cde
branch
3 participants
This enables by default an existing feature.
Follows #9746
Relates to #7496