Skip to content

Remove unused method and fix typo in BytecodeUtils #13886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 2 commits into from
Aug 29, 2022
Merged

Remove unused method and fix typo in BytecodeUtils #13886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c64d775
Fix typo in BytecodeUtils
tangjiangling Aug 28, 2022
c5e8917
Remove unused method in BytecodeUtils
tangjiangling Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions core/trino-main/src/main/java/io/trino/sql/gen/BytecodeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,25 +125,6 @@ public static BytecodeNode handleNullValue(
.ifTrue(isNull);
}

public static BytecodeNode boxPrimitive(Class<?> type)
{
BytecodeBlock block = new BytecodeBlock().comment("box primitive");
if (type == long.class) {
return block.invokeStatic(Long.class, "valueOf", Long.class, long.class);
}
if (type == double.class) {
return block.invokeStatic(Double.class, "valueOf", Double.class, double.class);
}
if (type == boolean.class) {
return block.invokeStatic(Boolean.class, "valueOf", Boolean.class, boolean.class);
}
if (type.isPrimitive()) {
throw new UnsupportedOperationException("not yet implemented: " + type);
}

return NOP;
}

public static BytecodeNode unboxPrimitive(Class<?> unboxedType)
{
BytecodeBlock block = new BytecodeBlock().comment("unbox primitive");
Expand Down Expand Up @@ -354,7 +335,7 @@ else if (type == ConnectorSession.class) {
lambdaArgumentIndex++;
break;
default:
throw new UnsupportedOperationException(format("Unsupported argument conventsion type: %s", invocationConvention.getArgumentConvention(realParameterIndex)));
throw new UnsupportedOperationException(format("Unsupported argument convention type: %s", invocationConvention.getArgumentConvention(realParameterIndex)));
}
realParameterIndex++;
}
Expand Down