Remove connector allow-all access control#13862
Closed
kokosing wants to merge 1 commit intotrinodb:masterfrom
Closed
Remove connector allow-all access control#13862kokosing wants to merge 1 commit intotrinodb:masterfrom
kokosing wants to merge 1 commit intotrinodb:masterfrom
Conversation
kokosing
commented
Aug 26, 2022
core/trino-main/src/test/java/io/trino/connector/AllowAllAccessControl.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Aug 26, 2022
core/trino-main/src/test/java/io/trino/connector/AllowAllAccessControl.java
Outdated
Show resolved
Hide resolved
System connector access control does exactly the same and does not break the system roles. Notice that allow-all connector access control says to the engine that it controls connector roles, while it has no roles.
kokosing
force-pushed
the
origin/master/309_allow_all
branch
from
617c69b to
dab3c6a
Compare
Member
Author
|
Addressed comments (AC). |
Member
Author
|
I cannot remove it :( It appeared that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove connector allow-all access control
System connector access control does exactly the same and does not break
the system roles. Notice that allow-all connector access control says to
the engine that it controls connector roles, while it has no roles.