Skip to content

Fix formatting and remove obsolete TODO in ClickHouseClient #13856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Aug 26, 2022
Merged

Fix formatting and remove obsolete TODO in ClickHouseClient #13856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce639b7
Fix formatting
tangjiangling Aug 26, 2022
3627a85
Remove obsolete TODO
tangjiangling Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,6 @@ public WriteMapping toWriteMapping(ConnectorSession session, Type type)
return WriteMapping.sliceMapping("String", varbinaryWriteFunction());
}
if (type == DATE) {
// TODO (https://github.com/trinodb/trino/issues/10055) Deny unsupported dates to prevent inserting wrong values. 2106-02-07 is max value in version 20.8
return WriteMapping.longMapping("Date", dateWriteFunctionUsingLocalDate());
}
if (type == TIMESTAMP_SECONDS) {
Expand Down Expand Up @@ -809,7 +808,8 @@ else if (address.length == 16) {

private static SliceWriteFunction ipAddressWriteFunction(String bindExpression)
{
return new SliceWriteFunction() {
return new SliceWriteFunction()
{
@Override
public String getBindExpression()
{
Expand Down