Improve type mapping documentation for Thrift connector#13853
Merged
hashhar merged 2 commits intotrinodb:masterfrom Aug 26, 2022
Merged
Improve type mapping documentation for Thrift connector#13853hashhar merged 2 commits intotrinodb:masterfrom
hashhar merged 2 commits intotrinodb:masterfrom
Conversation
hashhar
approved these changes
Aug 25, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Thanks. This is useful for consistency across connectors.
jhlodin
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a type mapping section that explains the thrift service defines data type support and mappings to Trino data types. The SMEs recommended this verbiage.
Documentation improvement
Thrift connector documentation
Added a section about type mapping above SQL support section.
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: