Make minValues and maxValues the same length as minMaxChannels#13845
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Aug 25, 2022
Merged
Conversation
Previously, the length of `minValues` and `maxValues` was the same as `channels`, which may exist the case that some elements in `minValues` and `maxValues` are null, so this commit keeps the length of `minValues` and `maxValues` the same as `minMaxChannels`, avoiding the case that some array elements may be null.
tangjiangling
requested review from
findepi,
losipiuk and
raunaqmorarka
and removed request for
findepi and
losipiuk
tangjiangling
added
the
no-release-notes
sopel39
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the length of
minValuesandmaxValueswas the same aschannels, which may exist the case that some elements inminValuesand
maxValuesare null, so this commit keeps the length ofminValuesand
maxValuesthe same asminMaxChannels, avoiding the case thatsome array elements may be null.
Description
Improvement
Core query engine.
N/A.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.