Skip to content

Avoid casting REAL into DOUBLE on is_nan() #13831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 25, 2022
Merged

Avoid casting REAL into DOUBLE on is_nan() #13831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/trino-main/src/main/java/io/trino/operator/scalar/MathFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,6 +1176,15 @@ public static boolean isNaN(@SqlType(StandardTypes.DOUBLE) double num)
return Double.isNaN(num);
}

@Description("Test if value is not-a-number")
@ScalarFunction("is_nan")
@SqlType(StandardTypes.BOOLEAN)
public static boolean isNaNReal(@SqlType(StandardTypes.REAL) long value)
{
float floatValue = intBitsToFloat(toIntExact(value));
return Float.isNaN(floatValue);
}

@Description("Test if value is finite")
@ScalarFunction
@SqlType(StandardTypes.BOOLEAN)
Expand Down
1 change: 1 addition & 0 deletions core/trino-main/src/test/java/io/trino/operator/scalar/TestMathFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@ public void testIsNaN()
assertFunction("is_nan(0.0E0 / 1.0E0)", BOOLEAN, false);
assertFunction("is_nan(infinity() / infinity())", BOOLEAN, true);
assertFunction("is_nan(nan())", BOOLEAN, true);
assertFunction("is_nan(REAL 'NaN')", BOOLEAN, true);
assertFunction("is_nan(REAL '0.0' / REAL '0.0')", BOOLEAN, true);
assertFunction("is_nan(REAL '0.0' / 1.0E0)", BOOLEAN, false);
assertFunction("is_nan(infinity() / infinity())", BOOLEAN, true);
Expand Down