Make external Exchange SPI as experimental.#13818
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Aug 26, 2022
Merged
Conversation
findepi
approved these changes
Aug 24, 2022
core/trino-spi/src/main/java/io/trino/spi/exchange/Exchange.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/exchange-spi-experimental
branch
from
0525dd6 to
291dd2c
Compare
arhimondr
approved these changes
Aug 24, 2022
Member
Author
|
@findepi it now complains that all Exchange SPI is missing, as we had it non-experimental in previous verison and it is experimental now (hence we filter it out). Any idea how should we handle that? I think adding everything to exception list is not the way to go ... |
Member
|
in |
Member
|
See also #13805 |
Change logic in TestSpiBackwardCompatibility so it allows for tagging existing SPI wiht @experimental annotation.
External exchange SPI is still under active development. Marking as experimenta to capture the current state.
losipiuk
force-pushed
the
lo/exchange-spi-experimental
branch
from
291dd2c to
0ee30c2
Compare
Member
Author
@findepi PTAL |
findepi
approved these changes
Aug 25, 2022
|
|
||
| // TODO remove this after Experimental is released | ||
| private static boolean isOriginalPtfClass(Class<?> clazz, boolean includeDeprecated) | ||
| private static boolean isOriginalPtfClass(Class<?> clazz, boolean includeDeprecatedAndExperimental) |
Member
There was a problem hiding this comment.
Looks like this method can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External exchange SPI is still under active development.
Marking as experimenta to capture the current state.
No RN/Docs