Conversation
BigQuery connector doesn't support fault tolerant execution yet.
|
While working on this I was also trying to add tests which CREATE TABLE, CTAS and INSERT into a non-lowercase schema and found that CTAS doesn't work with case-insensitive matching for some connectors: We cannot CTAS into non-lowercase schema in some connectors because the schema name of the output table handle (temporary table) doesn't match the schema name of the target table so it fails when calling I'm not going to fix it because I think it'd be a much better use of time to work on #17 instead (which I'm planning to pick up in my free time). |
| String schemaName = "Test_Create_Case_Sensitive_" + randomTableSuffix(); | ||
| assertUpdate("CREATE SCHEMA " + schemaName.toLowerCase(ENGLISH)); | ||
| assertQuery(format("SELECT schema_name FROM information_schema.schemata WHERE schema_name = '%s'", schemaName.toLowerCase(ENGLISH)), format("VALUES '%s'", schemaName.toLowerCase(ENGLISH))); | ||
| assertUpdate("DROP SCHEMA " + schemaName.toLowerCase(ENGLISH)); |
There was a problem hiding this comment.
@hashhar does this test have sense within CaseInsensitiveMapping class since all occurrences can be extracted
String lowerCase = schemaName.toLowerCase(ENGLISH);
and used through out the method?
Addresses comments from #13094