Change data ownership contract in call of ExchangeSink.add#13798
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Aug 24, 2022
Merged
Change data ownership contract in call of ExchangeSink.add#13798losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
Member
Author
|
@martint, @arhimondr do you think we need release notes for that? Technically it is SPI change yet I doubt there are any out of the tree implementations of this SPI part. |
arhimondr
approved these changes
Aug 23, 2022
Contributor
|
LGTM % checkstyle failure |
Member
BTW you can mark the interface |
Member
Author
I did not know that is the convention. |
After the change the contract changes in a way that ownership of data passed as an argument is passed from caller to callee. Apart from usage in DeduplicatingDirectExchangeBuffer the Slices passed as to ExchangeSink.add were single-use and not mutataded/reclaimed afterwards. The semantics change allows for simplere and more effective implementations of ExchangeSinks as no extra data copying is enforced.
losipiuk
force-pushed
the
lo/exchange-sink-data-owner-change
branch
from
6ae2264 to
bd84afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change the contract changes in a way that ownership of data
passed as an argument is passed from caller to callee.
Apart from usage in DeduplicatingDirectExchangeBuffer the Slices passed
as to ExchangeSink.add were single-use and not mutataded/reclaimed
afterwards.
The semantics change allows for simplere and more effective
implementations of ExchangeSinks as no extra data copying is enforced.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: