Skip to content

Make functionNullability property consistent in ResolvedFunction #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Apr 25, 2023
Merged

Make functionNullability property consistent in ResolvedFunction #13777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/trino-main/src/main/java/io/trino/metadata/ResolvedFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ public ResolvedFunction(
@JsonProperty("id") FunctionId functionId,
@JsonProperty("functionKind") FunctionKind functionKind,
@JsonProperty("deterministic") boolean deterministic,
@JsonProperty("nullability") FunctionNullability functionNullability,
@JsonProperty("functionNullability") FunctionNullability functionNullability,
@JsonProperty("typeDependencies") Map<TypeSignature, Type> typeDependencies,
@JsonProperty("functionDependencies") Set<ResolvedFunction> functionDependencies)
{
this.signature = requireNonNull(signature, "signature is null");
this.functionId = requireNonNull(functionId, "functionId is null");
this.functionKind = requireNonNull(functionKind, "functionKind is null");
this.deterministic = deterministic;
this.functionNullability = requireNonNull(functionNullability, "nullability is null");
this.functionNullability = requireNonNull(functionNullability, "functionNullability is null");
this.typeDependencies = ImmutableMap.copyOf(requireNonNull(typeDependencies, "typeDependencies is null"));
this.functionDependencies = ImmutableSet.copyOf(requireNonNull(functionDependencies, "functionDependencies is null"));
checkArgument(functionNullability.getArgumentNullable().size() == signature.getArgumentTypes().size(), "signature and functionNullability must have same argument count");
Expand Down