Remove RichColumnDescriptor from parquet module#13757
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Aug 26, 2022
Merged
Conversation
charlesjmorgan
force-pushed
the
cm/pq-prim-field
branch
2 times, most recently
from
1634195 to
048ac1a
Compare
skrzypo987
approved these changes
Aug 25, 2022
sopel39
reviewed
Aug 25, 2022
Member
There was a problem hiding this comment.
You didn't remove io.trino.parquet.RichColumnDescriptor class. Is it still used?
Could you improve commit description? Why we don't need io.trino.parquet.RichColumnDescriptor anymore
Member
Author
There was a problem hiding this comment.
Huh I thought I had removed it, it has been removed now. Commit message has been updated as well.
charlesjmorgan
force-pushed
the
cm/pq-prim-field
branch
from
048ac1a to
f22328e
Compare
RichColumnDescriptor seems to be a redundant class that is a wrapper on ColumnDescriptor. It has an extra field "required", but that field already exists in the Field/PrimitiveField classes. A simple solution to this is to remove RichColumnDescriptor and use the "required" variable that already exists in Field/PrimitiveField.
charlesjmorgan
force-pushed
the
cm/pq-prim-field
branch
from
f22328e to
8ee9321
Compare
sopel39
approved these changes
Aug 26, 2022
sopel39
reviewed
Sep 11, 2022
| private int nextBatchSize = INITIAL_BATCH_SIZE; | ||
| private final PrimitiveColumnReader[] columnReaders; | ||
| private final long[] maxBytesPerCell; | ||
| private final Map<Integer, PrimitiveColumnReader> columnReaders; |
Member
There was a problem hiding this comment.
Can this cause performance regression? Can it be primitive list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
RichColumnDescriptorclass in the parquet module seems a bit redundant. This PR removes that class from thePrimitiveFieldand replaces the columns field in theParquetReaderwith a list ofPrimitiveField'srefactor
Changes in parquet library and the update usages in hive, and iceberg
Remove a redundant class
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:
# Section