Retry Spark query when minReplication error happened#13743
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Aug 23, 2022
Merged
Retry Spark query when minReplication error happened#13743ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
Member
Author
|
https://github.com/trinodb/trino/runs/7911385034 |
ebyhr
force-pushed
the
ebi/iceberg-spark-retry
branch
from
c9c3a44 to
d49704b
Compare
ebyhr
changed the title
Member
Author
https://github.com/trinodb/trino/runs/7915590576 |
ebyhr
force-pushed
the
ebi/iceberg-spark-retry
branch
from
bef0d9f to
e93498d
Compare
ebyhr
force-pushed
the
ebi/iceberg-spark-retry
branch
from
e93498d to
98dd8e3
Compare
findepi
approved these changes
Aug 22, 2022
Member
There was a problem hiding this comment.
That may depend on Hadoop client version bundled.
That's probably whyb io.trino.tests.product.hive.HiveProductTest#ERROR_COMMITTING_WRITE_TO_HIVE_MATCH is an OR.
What about reusing that pattern, perhaps moving it out of the Hive-specific class (into some Hadoop-related class)?
ebyhr
force-pushed
the
ebi/iceberg-spark-retry
branch
from
98dd8e3 to
191dd7f
Compare
ebyhr
force-pushed
the
ebi/iceberg-spark-retry
branch
from
191dd7f to
17b07dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13601
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.