Fix running all ES plugin tests in the same JVM#13731
Merged
kokosing merged 2 commits intotrinodb:masterfrom Aug 20, 2022
Merged
Fix running all ES plugin tests in the same JVM#13731kokosing merged 2 commits intotrinodb:masterfrom
kokosing merged 2 commits intotrinodb:masterfrom
Conversation
Laonel
changed the title
kokosing
reviewed
Aug 18, 2022
...rino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
...rino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
...rino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
...elasticsearch/src/test/java/io/trino/plugin/elasticsearch/TestElasticsearchBackpressure.java
Outdated
Show resolved
Hide resolved
Laonel
force-pushed
the
fix-es-tests-stats-bean-names
branch
from
1935fd3 to
6578a02
Compare
hashhar
approved these changes
Aug 18, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % comment.
Thanks a lot for this improvement. This will reduce queuing on our CI as well.
...rino-elasticsearch/src/test/java/io/trino/plugin/elasticsearch/ElasticsearchQueryRunner.java
Outdated
Show resolved
Hide resolved
...elasticsearch/src/test/java/io/trino/plugin/elasticsearch/TestElasticsearchBackpressure.java
Outdated
Show resolved
Hide resolved
Laonel
force-pushed
the
fix-es-tests-stats-bean-names
branch
from
6578a02 to
794b058
Compare
kokosing
reviewed
Aug 18, 2022
| 1); | ||
| 1, | ||
| // Use a unique catalog name to make sure JMX stats beans are unique and not affected by other tests | ||
| "elasticsearch-backpressure"); |
Member
There was a problem hiding this comment.
Should we use something like io.trino.testing.sql.TestTable#randomTableSuffix? Or is it overkill?
Member
Author
There was a problem hiding this comment.
We might, I decided to go with a static name since this is executed just once for just one test.
A different approach could be to make the catalog name randomized on the ElasticsearchQueryRunner level, but since it was just the backpressure test causing the issue I decided to limit the changes to that test.
kokosing
approved these changes
Aug 20, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
io.trino.plugin.elasticsearch.TestElasticsearchBackpressureis currently being run in a separate CI job, because the JMX stats bean that is used verify backpressure would be overriden by other tests.To make this test work with all the others, we can rename the elasticsearch catalog in this test to a unique name, so that the JMX bean receives a unique name.
Fix
Tests of Elasticsearch connector
N/A
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: