Improve test time for testReadMetadataWithRelationsConcurrentModifications in Iceberg#13716
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Aug 18, 2022
Conversation
findinpath
force-pushed
the
findinpath/improve-test-time-for-testreadmetadatawithrelationsconcurrentmodifications-in-iceberg
branch
from
850e225 to
6392758
Compare
homar
approved these changes
Aug 17, 2022
Profiling of `testReadMetadataWithRelationsConcurrentModifications` with `TestIcebergParquetConnectorTest` shows that most time is spent listing metadata, and of which, most time is spending listing tables in the TESTING_FILE_METASTORE. This commit improves this by adding simple listing cache on top of the file system. Co-authored-by: Marius Grama <findinpath@gmail.com>
ebyhr
force-pushed
the
findinpath/improve-test-time-for-testreadmetadatawithrelationsconcurrentmodifications-in-iceberg
branch
from
6392758 to
c2c4e10
Compare
ebyhr
changed the title
ebyhr
approved these changes
Aug 18, 2022
ebyhr
added
the
no-release-notes
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13556
Builds on top of #13642 and adds just small cosmetic changes.
cc: @findepi - this PR is created to address the stringent issue of flaky test: #13556