Remove redundant iceberg.compression-codec in product test#13706
Remove redundant iceberg.compression-codec in product test#13706ebyhr merged 1 commit intotrinodb:masterfrom
iceberg.compression-codec in product test#13706Conversation
ZSTD was unsupported for old Iceberg Avro tables, but it's supported now.
| @@ -1277,8 +1277,8 @@ public void verifyCompressionCodecsDataProvider() | |||
| assertThat(onTrino().executeQuery("SHOW SESSION LIKE 'iceberg.compression_codec'")) | |||
There was a problem hiding this comment.
What is the purpose of this test ? Not sure why we want to assert on the default here.
Aren't we testing all compression codecs anyway ?
There was a problem hiding this comment.
What is the purpose of this test ?
I suppose the purpose is ensuring all supported compression codec in TestIcebergSparkCompatibility. If we add a new codec to the connector, this test will fail unless fixing storageFormatsAndCompressionCodecs
Aren't we testing all compression codecs anyway ?
We're testing all of them. Please take a look at TestIcebergSparkCompatibility.storageFormatsAndCompressionCodecs().
There was a problem hiding this comment.
Ah, okay got it now.
Could we update the assertion to match only the name and description columns ?
There was a problem hiding this comment.
I wouldn't modify at least for now. We may want to catch the default session property change here.
There was a problem hiding this comment.
If the purpose is to ensure that all the supported compression codecs are tested, it doesn't look like we should care about change in the default compression codec here. But not a blocker for this PR.
2 participants
Description
Remove redundant
iceberg.compression-codecin product testDocumentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.