Skip to content

Simplify boolean expressions and fix typo #13697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Aug 17, 2022
Merged

Simplify boolean expressions and fix typo #13697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08b646e
Simplify boolean expressions
tangjiangling Aug 17, 2022
44ac6e1
Fix typo in InternalHiveSplit
tangjiangling Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ public static int getMaxGroupingSets(Session session)

private static void validateHideInaccessibleColumns(boolean value, boolean defaultValue)
{
if (defaultValue == true && value == false) {
if (defaultValue && !value) {
throw new TrinoException(INVALID_SESSION_PROPERTY, format("%s cannot be disabled with session property when it was enabled with configuration", HIDE_INACCESSIBLE_COLUMNS));
}
}
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/metadata/MetadataListing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public static Map<SchemaTableName, List<ColumnMetadata>> listTableColumns(Sessio
}
}

if (redirectionSucceeded == false) {
if (!redirectionSucceeded) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/InternalHiveSplit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public class InternalHiveSplit
private final OptionalInt readBucketNumber;
private final OptionalInt tableBucketNumber;
// This supplier returns an unused statementId, to guarantee that created split
// files do not collide. Successive calls return the the next sequential integer,
// files do not collide. Successive calls return the next sequential integer,
// starting with zero.
private final Supplier<Integer> statementIdSupplier;
private final boolean splittable;
Expand Down