Improve type mapping documentation for Oracle connector#13659
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Aug 18, 2022
Merged
Improve type mapping documentation for Oracle connector#13659ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
jhlodin
suggested changes
Aug 15, 2022
Contributor
jhlodin
left a comment
jhlodin
left a comment
There was a problem hiding this comment.
Please add "No other types are supported" below each table
tlblessing
force-pushed
the
tb/oracle-type-mapping
branch
from
9d3847d to
bc3c7f4
Compare
Member
Author
Done in commit bc3c7f4 |
10 tasks
ebyhr
approved these changes
Aug 15, 2022
tlblessing
force-pushed
the
tb/oracle-type-mapping
branch
from
bc3c7f4 to
d092110
Compare
Member
Author
|
@ebyhr I think this PR is ready to merge now. Thank you! |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor documentation improvement for Oracle connector for consistency.
Added some boilerplate intro text only for reading and writing data type sections. Fixed table format for less wrapping.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: