Improve type mapping documentation for MariaDB connector#13656
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Aug 17, 2022
Merged
Improve type mapping documentation for MariaDB connector#13656ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
jhlodin
reviewed
Aug 12, 2022
10 tasks
ebyhr
reviewed
Aug 14, 2022
tlblessing
force-pushed
the
tb/maria-db-type-mapping
branch
2 times, most recently
from
aad24ae to
2b090da
Compare
Member
Author
|
@ebyhr thank you kindly for your thorough review. I am not sure how you want me to proceed for your comment #13656 (comment). Please review again at your earliest convenience. |
jhlodin
approved these changes
Aug 15, 2022
Contributor
jhlodin
left a comment
jhlodin
left a comment
There was a problem hiding this comment.
LGTM % any technical corrections
tlblessing
force-pushed
the
tb/maria-db-type-mapping
branch
from
2b090da to
758d578
Compare
jhlodin
approved these changes
Aug 15, 2022
mosabua
reviewed
Aug 15, 2022
mosabua
reviewed
Aug 15, 2022
mosabua
reviewed
Aug 15, 2022
mosabua
reviewed
Aug 15, 2022
tlblessing
force-pushed
the
tb/maria-db-type-mapping
branch
from
758d578 to
1387b39
Compare
tlblessing
force-pushed
the
tb/maria-db-type-mapping
branch
2 times, most recently
from
0e60b5f to
a87cdc0
Compare
mosabua
reviewed
Aug 16, 2022
mosabua
reviewed
Aug 16, 2022
tlblessing
force-pushed
the
tb/maria-db-type-mapping
branch
from
a87cdc0 to
1d9fd79
Compare
ebyhr
force-pushed
the
tb/maria-db-type-mapping
branch
from
1d9fd79 to
9ee6db4
Compare
ebyhr
approved these changes
Aug 17, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Doc improvement
Connector doc improvement
Add table for reverse mapping direction. Clean up table formatting.
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: