Analyze table function invocation in the context of a query#13653
Merged
kasiafi merged 3 commits intotrinodb:masterfrom Oct 13, 2022
Merged
Analyze table function invocation in the context of a query#13653kasiafi merged 3 commits intotrinodb:masterfrom
kasiafi merged 3 commits intotrinodb:masterfrom
Conversation
kasiafi
force-pushed
the
383TFRelationType
branch
from
fcc1239 to
9ad3215
Compare
kasiafi
force-pushed
the
383TFRelationType
branch
3 times, most recently
from
609acaa to
adea14e
Compare
kasiafi
force-pushed
the
383TFRelationType
branch
from
adea14e to
17a671d
Compare
kasiafi
force-pushed
the
383TFRelationType
branch
from
17a671d to
95b6781
Compare
kasiafi
force-pushed
the
383TFRelationType
branch
5 times, most recently
from
a850ca2 to
1e8016a
Compare
martint
reviewed
Oct 12, 2022
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
Table sample or MATCH_RECOGNIZE should not be applied to a polymorphic table function invocation. Per SQL standard, relation alias is required for a polymorphic table function with the GENERIC TABLE or static returned type, and it is not allowed for table function with ONLY PASS THROUGH returned type. We only enforce the latter rule.
kasiafi
force-pushed
the
383TFRelationType
branch
from
1e8016a to
02f3583
Compare
Member
Author
|
@martint I applied your comments. Please review. |
martint
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No release notes needed.
Docs: the limitations on TF usage should be documented. The documentation is not included in this PR.
Based on #13602 and #13649