Skip to content

Enhance timeout message in EventsAwaitingQueries #13647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
Aug 22, 2022
Merged

Enhance timeout message in EventsAwaitingQueries #13647

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa1f8ad
Enhance timeout message in EventsAwaitingQueries
findepi Aug 12, 2022
bbf9a50
empty
findepi Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,12 @@ public void waitForQueryCompletion(Duration timeout)

boolean finished = latch.await(timeout.toMillis(), MILLISECONDS);
if (!finished) {
throw new TimeoutException("Query did not complete in " + timeout);
synchronized (this) {
TimeoutException exception = new TimeoutException("Query did not complete in %s. Currently, queryCreatedEvent=%s queryCompletedEvent=%s queryCompleteLatch=%s"
.formatted(timeout, queryCreatedEvent, queryCompletedEvent, queryCompleteLatch));
failures.forEach(exception::addSuppressed);
throw exception;
}
}
}

Expand Down