Improve TestHiveConnectorTest test speed#13645
Merged
findepi merged 2 commits intotrinodb:masterfrom Aug 22, 2022
Merged
Conversation
Writing to tables takes about two thirds of execution time, and compression is apparently a dominant factor. Switch `TestHiveConnectorTest` to use ZSTD instead of default GZIP in hope this improves test execution speed. Very rough local testing showed about two-digit percent improvement, but the error margin was high.
findepi
added
test
no-release-notes
findepi
requested review from
ebyhr,
hashhar,
losipiuk,
raunaqmorarka and
sopel39
sopel39
approved these changes
Aug 12, 2022
| .put("hive.storage-format", "TEXTFILE") // so that there's no minimum split size for the file | ||
| .put("hive.compression-codec", "NONE") // so that the file is splittable | ||
| .buildOrThrow(); | ||
| hiveBucketedProperties = new HashMap<>(hiveBucketedProperties); |
Member
Author
There was a problem hiding this comment.
it's intentional. i need to override compression for the second catalog gets registered here
raunaqmorarka
approved these changes
Aug 12, 2022
homar
approved these changes
Aug 12, 2022
| { | ||
| // Use faster compression codec in tests. TODO remove explicit config when default changes | ||
| verify(new HiveConfig().getHiveCompressionCodec() == HiveCompressionOption.GZIP); | ||
| String hiveCompressionCodec = HiveCompressionCodec.ZSTD.name(); |
Member
Author
There was a problem hiding this comment.
you mean to use "ZSTD" string literal? i think the current way describes which enum this is referring to
ebyhr
approved these changes
Aug 14, 2022
findepi
deleted the
findepi/improve-testhiveconnectortest-test-speed-bfaa0a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing to tables takes about two thirds of execution time, and
compression is apparently a dominant factor. Switch
TestHiveConnectorTestto use ZSTD instead of default GZIP in hope thisimproves test execution speed. Very rough local testing showed about
two-digit percent improvement, but the error margin was high.