Conversation
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/prefetch-ryuk-image-with-retries-214c8d
branch
from
26b4844 to
d79a5dc
Compare
According to https://nineinchnick.github.io/trino-cicd/reports/flaky/, HTTP 500 when getting `testcontainers/ryuk` is not uncommon source of test flakiness. Let's try to improve the situation by fetching the image before tests are started.
findepi
force-pushed
the
findepi/prefetch-ryuk-image-with-retries-214c8d
branch
from
d79a5dc to
b5f7dff
Compare
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
@nineinchnick how i should add this to ci.yml?
where else i should add this?
PTs for sure, others?
There was a problem hiding this comment.
IIRC @nineinchnick is working on a change that will extract common code to separate step extracted as separate file. Then it will be easy to add such changes
| @@ -458,6 +458,9 @@ jobs: | |||
| run: | | |||
There was a problem hiding this comment.
This change is not going to help:(
We blame ryuk because it is downloaded first. I disabled downloading ryuk in the past and it was still failing on other images.
If we could pre-download images before running tests then we would avoid flakiness of docker registries. Cc @ppalucha
There was a problem hiding this comment.
We blame ryuk because it is downloaded first.
you're right.
I disabled downloading ryuk in the past and it was still failing on other images.
Maybe if we retry long enough to download ryuk we cover for the short unavailability of the docker hub.
So it depends on the unavailability pattern (total vs % requests dropped).
Also, wonder whether testcontainers library does / can do retries for all images it downloads.
There was a problem hiding this comment.
Also, wonder whether testcontainers library does / can do retries for all images it downloads.
|
Superseded by #13774 |
3 participants
According to https://nineinchnick.github.io/trino-cicd/reports/flaky/,
HTTP 500 when getting
testcontainers/ryukis not uncommon source oftest flakiness. Let's try to improve the situation by fetching the image
before tests are started.