Skip to content

Verify database name explicitly in File metastore#13632

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/hive-verify-database-name
Aug 12, 2022
Merged

Verify database name explicitly in File metastore#13632
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/hive-verify-database-name

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Aug 12, 2022

Description

Verify database name explicitly in File metastore
Fixes #13600

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

testCreateSchemaWithLongName and testRenameSchemaToLongName in
BaseConnectorTest expect throwing an exception when the schema
name length is longer than the limitation, but File metastore
sometimes doesn't throw an exception. This change ensures an
exception by verifying the name explicitly.
@ebyhr ebyhr force-pushed the ebi/hive-verify-database-name branch from b55e767 to 662e9ff Compare August 12, 2022 07:38
@ebyhr ebyhr requested review from findepi and hashhar August 12, 2022 07:39
@ebyhr
Copy link
Member Author

ebyhr commented Aug 12, 2022

CI hit #13322

@ebyhr ebyhr merged commit 169349e into trinodb:master Aug 12, 2022
@ebyhr ebyhr deleted the ebi/hive-verify-database-name branch August 12, 2022 12:05
@github-actions github-actions bot added this to the 393 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

TestHiveConnectorTest.testCreateSchemaWithLongName is flaky

2 participants