Fix handing of grouped ordered aggregations with filtering#13627
Merged
dain merged 1 commit intotrinodb:masterfrom Aug 13, 2022
Merged
Fix handing of grouped ordered aggregations with filtering#13627dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
dain
force-pushed
the
ordered-aggregation-filtered-out
branch
from
cc73d94 to
b9760cb
Compare
findepi
reviewed
Aug 12, 2022
core/trino-main/src/test/java/io/trino/sql/query/TestOrderedAggregation.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Aug 12, 2022
Member
There was a problem hiding this comment.
the same seems to be required for DistinctAccumulator
Member
Author
There was a problem hiding this comment.
Good catch. I looked at DistinctAccumulator also, and missed the place where it skips input
Member
Author
There was a problem hiding this comment.
The existing distinct code is correct, but I added a test to verify that we don't introduce this bug in that code (also, I verified the test catches the bug if we change the code). I also added a comment to the distinct code to remind people about the issue
When a grouped ordered aggregation input is completely filtered, the underlying aggregation must still be informed of the empty groups.
dain
force-pushed
the
ordered-aggregation-filtered-out
branch
from
b9760cb to
363ae5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a grouped ordered aggregation input is completely filtered, the underlying aggregation must still be informed of the empty groups.
Related issues, pull requests, and links
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(X) Release notes entries required with the following suggested text: