Skip to content

Simplify casts in TestDomainTranslator #13615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
Aug 12, 2022
Merged

Simplify casts in TestDomainTranslator #13615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
308988b
Simplify casts in TestDomainTranslator
findepi Aug 10, 2022
cc8256f
Remove redundant final on QueryAssert methods
findepi Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/trino-main/src/test/java/io/trino/sql/planner/TestDomainTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,30 +838,30 @@ public void testNonImplicitCastOnSymbolSide()
// we expect TupleDomain.all here().
// see comment in DomainTranslator.Visitor.visitComparisonExpression()
assertUnsupportedPredicate(equal(
new Cast(C_TIMESTAMP.toSymbolReference(), toSqlType(DATE)),
cast(C_TIMESTAMP, DATE),
toExpression(DATE_VALUE, DATE)));
assertUnsupportedPredicate(equal(
new Cast(C_DECIMAL_12_2.toSymbolReference(), toSqlType(BIGINT)),
cast(C_DECIMAL_12_2, BIGINT),
bigintLiteral(135L)));
}

@Test
public void testNoSaturatedFloorCastFromUnsupportedApproximateDomain()
{
assertUnsupportedPredicate(equal(
new Cast(C_DECIMAL_12_2.toSymbolReference(), toSqlType(DOUBLE)),
cast(C_DECIMAL_12_2, DOUBLE),
toExpression(12345.56, DOUBLE)));

assertUnsupportedPredicate(equal(
new Cast(C_BIGINT.toSymbolReference(), toSqlType(DOUBLE)),
cast(C_BIGINT, DOUBLE),
toExpression(12345.56, DOUBLE)));

assertUnsupportedPredicate(equal(
new Cast(C_BIGINT.toSymbolReference(), toSqlType(REAL)),
cast(C_BIGINT, REAL),
toExpression(realValue(12345.56f), REAL)));

assertUnsupportedPredicate(equal(
new Cast(C_INTEGER.toSymbolReference(), toSqlType(REAL)),
cast(C_INTEGER, REAL),
toExpression(realValue(12345.56f), REAL)));
}

Expand Down
8 changes: 4 additions & 4 deletions core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ public QueryAssert matches(MaterializedResult expected)
});
}

public final QueryAssert matches(PlanMatchPattern expectedPlan)
public QueryAssert matches(PlanMatchPattern expectedPlan)
{
transaction(runner.getTransactionManager(), runner.getAccessControl())
.execute(session, session -> {
Expand Down Expand Up @@ -471,7 +471,7 @@ public final QueryAssert isNotFullyPushedDown(Class<? extends PlanNode>... retai
* <b>Note:</b> the primary intent of this assertion is to ensure the test is updated to {@link #isFullyPushedDown()}
* when pushdown capabilities are improved.
*/
public final QueryAssert isNotFullyPushedDown(PlanMatchPattern retainedSubplan)
public QueryAssert isNotFullyPushedDown(PlanMatchPattern retainedSubplan)
{
PlanMatchPattern expectedPlan = PlanMatchPattern.anyTree(retainedSubplan);

Expand All @@ -489,12 +489,12 @@ public final QueryAssert isNotFullyPushedDown(PlanMatchPattern retainedSubplan)
* Verifies query has the expected plan and that results are the same as when pushdown is fully disabled.
*/
@CanIgnoreReturnValue
public final QueryAssert hasPlan(PlanMatchPattern expectedPlan)
public QueryAssert hasPlan(PlanMatchPattern expectedPlan)
{
return hasPlan(expectedPlan, plan -> {});
}

private final QueryAssert hasPlan(PlanMatchPattern expectedPlan, Consumer<Plan> additionalPlanVerification)
private QueryAssert hasPlan(PlanMatchPattern expectedPlan, Consumer<Plan> additionalPlanVerification)
{
transaction(runner.getTransactionManager(), runner.getAccessControl())
.execute(session, session -> {
Expand Down