Move ThriftHiveMetastore alternate calls system to ThriftHiveMetastoreClient#13610
Merged
dain merged 3 commits intotrinodb:masterfrom Aug 13, 2022
Merged
Move ThriftHiveMetastore alternate calls system to ThriftHiveMetastoreClient#13610dain merged 3 commits intotrinodb:masterfrom
dain merged 3 commits intotrinodb:masterfrom
Conversation
electrum
approved these changes
Aug 12, 2022
...src/main/java/io/trino/plugin/hive/metastore/thrift/KerberosHiveMetastoreAuthentication.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftMetastoreAuthenticationModule.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/MockThriftMetastoreClient.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/MockThriftMetastoreClient.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
hive-metastore-alternate-calls
branch
from
c2d4ba8 to
e6de085
Compare
dain
force-pushed
the
hive-metastore-alternate-calls
branch
from
e6de085 to
429d217
Compare
Member
|
What would be the best way to frame this release note so it's providing a tangible improvement to users? It is a performance improvement, a reduction in bandwidth usage, something else? |
findepi
reviewed
Oct 26, 2022
Comment on lines
+51
to
+52
| // When `dateStatistics.size() > 1` we expect something like "TApplicationException: Required field 'colName' is unset! Struct:ColumnStatisticsObj(colName:null, colType:null, statsData:null)" | ||
| // When `dateStatistics.size() == 1` we expect something like "TTransportException: java.net.SocketTimeoutException: Read timed out" |
Member
There was a problem hiding this comment.
What does dateStatistics refer to?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change moves the logic for discovering and managing alternate Thrift calls for the various version of Hive Metastore to the lowest level ThriftHiveMetastoreClient. This simplifies callers because they do not need understand complexity of API versions, and instead callers just issue simple commands.
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(X) Release notes entries required with the following suggested text: