Add DataStax Enterprise as a Cassandra test environment#13597
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Aug 16, 2022
Merged
Add DataStax Enterprise as a Cassandra test environment#13597ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
ebyhr
reviewed
Aug 10, 2022
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Aug 10, 2022
Comment on lines
33
to
34
Member
There was a problem hiding this comment.
nit
Imo it's better if the two come together as a single String
Suggested change
| "datastax/dse-server", | |
| "6.8.25", | |
| "datastax/dse-server:6.8.25", |
.../trino-cassandra/src/test/java/io/trino/plugin/cassandra/TestDatastaxConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Aug 10, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Could you please reorder the commit as
- Merge docker image name and tag in Cassandra
- Change Cassandra port in cu-casandra.yaml
- Add DataStax Enterprise as a Cassandra test environment
The preparatory commits should be first.
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java
Outdated
Show resolved
Hide resolved
kamil-rafalko
force-pushed
the
datastax-test-environment
branch
3 times, most recently
from
bbcc30d to
8bca8be
Compare
kamil-rafalko
force-pushed
the
datastax-test-environment
branch
from
119882c to
17ea897
Compare
kamil-rafalko
force-pushed
the
datastax-test-environment
branch
from
8083a12 to
82b44f6
Compare
Member
Author
|
@ebyhr I think I've managed to fix unstable tests. It turned out that path that we currently use as a |
ebyhr
approved these changes
Aug 16, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new test environment to the Cassandra connector smoke tests in particular DataStax Enterprise in version 6.8.25 (for more information please visit docs)
Related issues, pull requests, and links
Closes #10444
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: